Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove a leftover dbg() statement #663

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Remove a leftover dbg() statement #663

merged 2 commits into from
Jan 8, 2024

Conversation

mjameswh
Copy link
Contributor

@mjameswh mjameswh commented Jan 6, 2024

What was changed

  • Remove a leftover dbg!() statement

Why?

  • @antlai-temporal's investigation identified this as probable cause of some recent failures in TS SDK's tests.

@mjameswh mjameswh requested a review from a team as a code owner January 6, 2024 00:25
@mjameswh
Copy link
Contributor Author

mjameswh commented Jan 6, 2024

Running tests right now on TS SDK with this change included to validate that this resolve observed flakes (see GHA).

@antlai-temporal antlai-temporal mentioned this pull request Jan 8, 2024
Closed
@mjameswh mjameswh merged commit a764405 into master Jan 8, 2024
7 checks passed
@mjameswh mjameswh deleted the remove-dbg branch January 8, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cretz cretz cretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjameswh @cretz